Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release] v6.1.2 #43957

Merged
merged 16 commits into from
Oct 2, 2024
Merged

[release] v6.1.2 #43957

merged 16 commits into from
Oct 2, 2024

Conversation

aarongarciah
Copy link
Member

No description provided.

@aarongarciah aarongarciah added the release We are shipping :D label Oct 1, 2024
@aarongarciah aarongarciah marked this pull request as ready for review October 1, 2024 13:30
@aarongarciah aarongarciah requested a review from a team October 1, 2024 13:31
@mui-bot
Copy link

mui-bot commented Oct 1, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43957--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 27b0a07

mnajdova
mnajdova approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a comment for small nit.

CHANGELOG.md Outdated Show resolved Hide resolved
@aarongarciah aarongarciah force-pushed the release/6.1.2 branch 2 times, most recently from 4cff43a to 0a9fef9 Compare October 2, 2024 08:19
@aarongarciah
Copy link
Member Author

aarongarciah commented Oct 2, 2024 •
edited
Loading

After running pnpm dedupe building the docs results in an error: nextExternals is not a function. After running pnpm dedupe, next is pointed to ^14.2.14 instead of ^14.2.13, but I haven't found the root problem just yet. Apparently no other users with this problem just yet.

@aarongarciah
Copy link
Member Author

aarongarciah commented Oct 2, 2024 •
edited
Loading

This change in next is the culprit: https://github.com/vercel/next.js/pull/70382/files#diff-5f441142eb8ba9bcba515aa36fbc420a113307bd191e54a4e9e6c43529fc2613R861

I'll fix it in another PR and come back to this one.

edit: PR updating Next.js to v14.2.14 and fixing the config #43964

@aarongarciah aarongarciah mentioned this pull request Oct 2, 2024
Closed
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 2, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 2, 2024
@aarongarciah aarongarciah merged commit e6ff0b5 into mui:master Oct 2, 2024
19 checks passed
oliviertassinari
oliviertassinari reviewed Oct 2, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@aarongarciah aarongarciah deleted the release/6.1.2 branch October 2, 2024 15:27
@aarongarciah aarongarciah mentioned this pull request Oct 2, 2024
Merged
@aarongarciah
Copy link
Member Author

@oliviertassinari comments addressed in #43968

This was referenced Oct 11, 2024
Merged
Merged
@aarongarciah aarongarciah mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp left review comments

@DiegoAndai DiegoAndai DiegoAndai left review comments

@oliviertassinari oliviertassinari oliviertassinari left review comments

@Janpot Janpot Janpot left review comments

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
release We are shipping :D
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aarongarciah @mui-bot @Janpot @oliviertassinari @mnajdova @DiegoAndai @siriwatknp