Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][LinearProgress] Fix background color #43949

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Oct 1, 2024

feedback from slack

When inheritting color, one of the bars has wrong color/opacity

Steps to reproduce the issue

  1. open https://mui.com/material-ui/react-progress/#linear-color
  2. Notice that the background color for the linear progress with color=inherit bar gets applied alternately, working for first time but not the second.
  3. In v5 it does but bot in v6.

v5 demo: https://v5.mui.com/material-ui/react-progress/#linear-color

Below code is from v5 branch, following branch got missed while migrating to use pigment-css

...(ownerState.variant !== 'buffer' && {
backgroundColor:
ownerState.color === 'inherit'
? 'currentColor'

Preview: https://deploy-preview-43949--material-ui.netlify.app/material-ui/react-progress/

@sai6855 sai6855 marked this pull request as draft October 1, 2024 06:17
@mui-bot
Copy link

mui-bot commented Oct 1, 2024

Netlify deploy preview

https://deploy-preview-43949--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 7cc4560

@sai6855 sai6855 added bug 🐛 Something doesn't work component: LinearProgress The React component. package: material-ui Specific to @mui/material labels Oct 1, 2024
@sai6855 sai6855 marked this pull request as ready for review October 1, 2024 06:31
@aarongarciah aarongarciah merged commit bef8afa into mui:master Oct 1, 2024
21 of 22 checks passed
@sai6855 sai6855 deleted the colors-inherit-fix branch October 1, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: LinearProgress The React component. package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants