Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button] ignore dark and contrastText if not provided in the theme #43861

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Sep 23, 2024

@siriwatknp siriwatknp added regression A bug, but worse component: button This is the name of the generic UI component, not the React module! v6.x labels Sep 23, 2024
@mui-bot
Copy link

mui-bot commented Sep 23, 2024

Netlify deploy preview

https://deploy-preview-43861--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 77c356c

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would recommend adding a regression test.

@mnajdova mnajdova merged commit 50d8c3b into mui:master Sep 26, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module! regression A bug, but worse v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom theme colors breaking MuiButton in Material UI v6
3 participants