-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix visual bug on dashboard template #43836
Merged
oliviertassinari
merged 1 commit into
mui:master
from
oliviertassinari:template-fix-scroll
Sep 26, 2024
Merged
[docs] Fix visual bug on dashboard template #43836
oliviertassinari
merged 1 commit into
mui:master
from
oliviertassinari:template-fix-scroll
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43836--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
template-fix-scroll
branch
from
September 21, 2024 15:10
42e74d6
to
2840d03
Compare
oliviertassinari
added
the
design
This is about UI or UX design, please involve a designer
label
Sep 21, 2024
zanivan
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling this! The large bottom padding was due to the old theme switcher, which might have slipped through in my reviews.
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
This was referenced Oct 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is so much space for the footer in https://deploy-preview-43604--material-ui.netlify.app/material-ui/getting-started/templates/dashboard/, it's weird.
Preview: https://deploy-preview-43836--material-ui.netlify.app/material-ui/getting-started/templates/dashboard/
An iteration on #41469.