Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][material-ui] Improved documentation for indeterminateIcon prop #43791

Merged
merged 4 commits into from
Oct 9, 2024
Merged

[docs][material-ui] Improved documentation for indeterminateIcon prop #43791

merged 4 commits into from
Oct 9, 2024

Conversation

marctaylor01
Copy link
Contributor

@marctaylor01 marctaylor01 commented Sep 17, 2024 •
edited
Loading

I have added more detailed documentation about how do customize the indeterminate icon for the
checkbox component.

Fixes #43499

@marctaylor01 marctaylor01 changed the title [docs][material-ui] Improved documentation for indeterminateIcon prop #43499 [docs][material-ui] Improved documentation for indeterminateIcon prop Sep 17, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 17, 2024
@mui-bot
Copy link

mui-bot commented Sep 17, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 4396a53

@zannager zannager added the docs Improvements or additions to the documentation label Sep 17, 2024
@marctaylor01
Copy link
Contributor Author

Hey @aarongarciah !
I'm very new to open source and was wondering what I should do about my pull request. On the first PR the "ci/circleci: checkout" test did not pass, so I ran pnpm deduplicate according to the CONTRIBUTE.md file. The test passed but the pnpm-lock.yaml file now has merge conflicts which I do not really understand, could you help me into correct direction of what to do next?

image

Thanks in advance! :)

@aarongarciah
Copy link
Member

Hey @marctaylor01! Thanks for opening the PR. I'll review it next week, but you'll need to undo changes in the pnpm-lock.yaml file and rebase this PR on top of master.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 30, 2024
@marctaylor01
Copy link
Contributor Author

Hey @aarongarciah!
I've done the changes as mentioned and was wondering how it's looking with the PR review?

aarongarciah
aarongarciah reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Left a couple of comments.

docs/data/material/components/checkboxes/checkboxes.md Outdated Show resolved Hide resolved
docs/data/material/components/checkboxes/IndeterminateCheckbox.tsx Outdated Show resolved Hide resolved
@aarongarciah aarongarciah merged commit 630da1c into mui:master Oct 9, 2024
22 checks passed
@aarongarciah
Copy link
Member

Thank you @marctaylor01!

This was referenced Oct 31, 2024
Merged
Merged
@Souviksamanta34 Souviksamanta34 mentioned this pull request Oct 31, 2024
Open
@bansikah22 bansikah22 mentioned this pull request Oct 31, 2024
Open
This was referenced Oct 31, 2024
Open
Open
This was referenced Nov 1, 2024
Open
Open
@josetutis josetutis mentioned this pull request Nov 2, 2024
Open
@Hoang-Nguyen-Huy Hoang-Nguyen-Huy mentioned this pull request Nov 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongarciah aarongarciah aarongarciah approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] IndeterminateIcon is Missing From Checkbox Docs
4 participants
@marctaylor01 @mui-bot @aarongarciah @zannager