-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[slider][docs] Polish Music player demo #43748
Merged
oliviertassinari
merged 1 commit into
mui:master
from
oliviertassinari:slider-docs-polish
Sep 15, 2024
Merged
[slider][docs] Polish Music player demo #43748
oliviertassinari
merged 1 commit into
mui:master
from
oliviertassinari:slider-docs-polish
Sep 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
Improvements or additions to the documentation
component: slider
This is the name of the generic UI component, not the React module!
labels
Sep 13, 2024
Netlify deploy previewBundle size report |
aarongarciah
approved these changes
Sep 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the data grid demos linked in the PR description, I doubt it would work without 😁 |
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: slider
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick polish on #43743. I thought this would look better and be denser, using less vertical space:
Before
After
This docs option is not used so often on Material UI. We use it a lot with the MUI X Data Grid though, e.g. https://mui.com/x/react-data-grid/#mit-license-free-forever