-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Paper] Fix wrong background-image on Paper when elevation is 0 #43723
Merged
ZeeshanTamboli
merged 9 commits into
mui:master
from
ZeeshanTamboli:issue-43683-paper-wrong-background-image-elevation-0
Sep 13, 2024
Merged
[material-ui][Paper] Fix wrong background-image on Paper when elevation is 0 #43723
ZeeshanTamboli
merged 9 commits into
mui:master
from
ZeeshanTamboli:issue-43683-paper-wrong-background-image-elevation-0
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
component: Paper
This is the name of the generic UI component, not the React module!
package: material-ui
Specific to @mui/material
labels
Sep 12, 2024
Netlify deploy previewhttps://deploy-preview-43723--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
ZeeshanTamboli
commented
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to run pnpm dedupe
.
ZeeshanTamboli
changed the title
[material-ui][Paper] Fix wrong Paper background-image when elevation is 0
[material-ui][Paper] Fix wrong background-image on Paper when elevation is 0
Sep 12, 2024
siriwatknp
approved these changes
Sep 13, 2024
ZeeshanTamboli
deleted the
issue-43683-paper-wrong-background-image-elevation-0
branch
September 13, 2024 06:52
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: Paper
This is the name of the generic UI component, not the React module!
package: material-ui
Specific to @mui/material
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43683
Before: https://codesandbox.io/p/sandbox/material-ui-cra-ts-forked-krmnq8?file=%2Fsrc%2FApp.tsx%3A9%2C4&workspaceId=92b035ba-df9d-45a7-90b6-6b416aafd4ba
After: https://codesandbox.io/p/sandbox/material-ui-cra-ts-forked-vrjwyk?file=%2Fsrc%2FApp.tsx%3A9%2C4