[material-ui] Bring back GridProps and GridTypeMap
#43717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43717--material-ui.netlify.app/ Bundle size report |
siriwatknp
approved these changes
Sep 12, 2024
heath-freenome
approved these changes
Sep 12, 2024
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43686.
This was an oversight of #43054. This only brings back the types requested in the issue, as there are some naming conflicts between the
GridandGrid2other types exports (GridDirection,GridSpacing,GridWrapandGridSize), so adding those back would be opening a bigger can of worms. Hopefully, no one is using them, but if someone is and opens an issue, we can discuss possible solutions then.