[docs-infra] Fix missing dependencies in multi-tab demos #43713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes missing dependencies when opening demo in Stackblitz
Netlify deploy previewhttps://deploy-preview-43713--material-ui.netlify.app/ Bundle size report |
1 task
bharatkashyap
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Looks good! Thanks @cherniavskii, real power use of the multi tabs feature 😄
|
The agros diff is not related to changes in this PR and seems to be restoring the proper screenshot after the wrong one was committed to the |
1 task
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mui/mui-x#13695 (comment)
When multi-tab demos are opened in Stackblitz/Codesandbox, we need to extract imported dependencies from all the files, not only the main ones.
Before: https://deploy-preview-43696--material-ui-apps.netlify.app/experiments/docs/demos/#multiple-tabs-demo
After: https://deploy-preview-43713--material-ui-apps.netlify.app/experiments/docs/demos/#multiple-tabs-demo
TODO