Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix API search link regression #43662

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 8, 2024

The change in #43292 breaks the search experience on the API pages that have the "View: Expanded" default layout, for example https://mui.com/x/api/data-grid/data-grid-pro/. Algolia returns URLs with the React useId, e.g. https://mui.com/x/api/data-grid/data-grid/#:R86ml5l6kud6:. I believe this will fix it.

Preview: https://deploy-preview-43662--material-ui.netlify.app/material-ui/api/button/#button-prop-color

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work regression A bug, but worse scope: docs-infra Specific to the docs-infra product labels Sep 8, 2024
@mui-bot
Copy link

mui-bot commented Sep 8, 2024

Netlify deploy preview

https://deploy-preview-43662--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 30118c2

@zannager zannager requested a review from Janpot September 9, 2024 14:22
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the accessibility tree it seems to have a drastic effect on the label.
Screenshot 2024-09-09 at 18 01 06
vs.
Screenshot 2024-09-09 at 18 01 16

Then again, the whole branch seems to be ignored anyway, so why were we doing this in the first place 😄

in any case, neither of those labels describe the control very well

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Sep 11, 2024

People start to open issues with the wrong hashes 😄, e.g. mui/mui-x#14585

SCR-20240911-sbov

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Sep 11, 2024

Looking at the accessibility tree it seems to have a drastic effect on the label.

Yeah, ok, fixed:

Before:

SCR-20240911-sifr

After:

SCR-20240911-sicb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work regression A bug, but worse scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants