Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][material-ui][Autocomplete] Fix GitHubLabel demo input background color #43599

Merged
merged 3 commits into from
Sep 4, 2024
Merged

[docs][material-ui][Autocomplete] Fix GitHubLabel demo input background color #43599

merged 3 commits into from
Sep 4, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Sep 4, 2024 •
edited
Loading

@sai6855 sai6855 added bug 🐛 Something doesn't work docs Improvements or additions to the documentation component: autocomplete This is the name of the generic UI component, not the React module! labels Sep 4, 2024
@mui-bot
Copy link

mui-bot commented Sep 4, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43599--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against cd67a18

@sai6855 sai6855 changed the title [Autocomplete] Fix Githublabel demo background color [material-ui][Autocomplete] Fix Githublabel demo background color Sep 4, 2024
@sai6855 sai6855 marked this pull request as draft September 4, 2024 05:24
@sai6855 sai6855 marked this pull request as ready for review September 4, 2024 05:27
@sai6855 sai6855 mentioned this pull request Sep 4, 2024
Closed
mnajdova
mnajdova approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][Autocomplete] Fix Githublabel demo background color [docs][material-ui][Autocomplete] Fix Githublabel demo background color Sep 4, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui][Autocomplete] Fix Githublabel demo background color [docs][material-ui][Autocomplete] Fix GitHubLabel demo background color Sep 4, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui][Autocomplete] Fix GitHubLabel demo background color [docs][material-ui][Autocomplete] Fix GitHubLabel demo input background color Sep 4, 2024
ZeeshanTamboli
ZeeshanTamboli approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. PR title should have [docs] tag when it's documentation related changes.

@ZeeshanTamboli ZeeshanTamboli merged commit c7cd5bd into mui:master Sep 4, 2024
22 checks passed
This was referenced Oct 3, 2024
Open
Open
This was referenced Oct 3, 2024
Open
Open
@Msolmaz4 Msolmaz4 mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs][material-ui][Autocomplete] Wrong background color applied to gihub label demo
4 participants
@sai6855 @mui-bot @mnajdova @ZeeshanTamboli