-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Reduce description max-length #43562
Merged
oliviertassinari
merged 2 commits into
mui:master
from
oliviertassinari:try-to-reduce-description-max-length
Sep 2, 2024
Merged
[docs-infra] Reduce description max-length #43562
oliviertassinari
merged 2 commits into
mui:master
from
oliviertassinari:try-to-reduce-description-max-length
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43562--material-ui.netlify.app/ Bundle size report |
oliviertassinari
added
bug 🐛
Something doesn't work
and removed
enhancement
This is not a bug, nor a new feature
labels
Sep 1, 2024
samuelsycamore
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call 👍 This is also a good reminder that these kinds of best practices should be documented on Notion for future reference.
This was referenced Sep 25, 2024
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
regression
A bug, but worse
scope: docs-infra
Specific to the docs-infra product
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce max length in code, from 170 down to 160. I suspect we should go as far as 150, but maybe for another time.
See https://www.reddit.com/r/SEO/comments/14rc47l/meta_description_too_long_advice/. Meta descriptions are not used for SEO, but to improve the CTR on the search result. So if they are truncated, it defeats their purpose;
"nextjs 15 release", fits
"material ui v6 release", doesn't fit
I suspect that https://nextjs.org/blog/ are authors in the same underlying infra as https://vercel.com/blog/, but show in a different URL path. It's not a coincidence that all their posts's descriptions are short. This might look like a detail, but I think it's this kind of depth of execution difference that compounds and separates the great UX from the good ones.
Saw this from https://app.ahrefs.com/site-audit/2944028/data-explorer?columns=pageRating%2Curl%2Ctraffic%2ChttpCode%2Cdepth%2CmetaDescription%2CmetaDescriptionLength%2CnrMetaDescription%2Ccompliant¤t=30-08-2024T023527&filterId=2864d4a78dbccdda9cf9629aa273bd61&issueId=c64d56c9-d0f4-11e7-8ed1-001e67ed4656.