-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][material-ui] Fix template shadow tokens #43514
Conversation
Hey @zanivan! I think there's no need to copy the default shadows manually. Here's an example with a simplified version of the code: https://stackblitz.com/edit/stackblitz-starters-apzykp?file=src%2FApp.tsx In material-ui/docs/data/material/getting-started/templates/shared-theme/themePrimitives.ts Line 25 in 80237a4
Let's change it to defaultTheme .
|
Netlify deploy previewhttps://deploy-preview-43514--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we look into sharing the TemplateFrame
files as well? (having one source as we do with the themes)
This would be very helpful 🙏 |
Fixes item 24 from #41469
Based on #43369 from @Andarist, this PR fixes the shadows in the custom theme of the templates and adds the 23 remaining shadow tokens from the default theme.