-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Add closing message workflow #43450
Merged
michelengelen
merged 5 commits into
mui:master
from
michelengelen:automation/add-closing-message
Aug 26, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a23bbf2
added closed issue message workflow
michelengelen 9284568
changed revision to a commit SHA
michelengelen b67700b
added state_reason check to only run this on "completed" issues
michelengelen 8382256
added closing reason to stackoverflow workflow to prevent closing mes…
michelengelen 0dde9b5
Merge remote-tracking branch 'refs/remotes/upstream/master' into auto…
michelengelen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
name: Add closing message to issue | ||
|
||
on: | ||
issues: | ||
types: | ||
- closed | ||
workflow_call: | ||
|
||
permissions: {} | ||
|
||
jobs: | ||
add-comment: | ||
name: Add closing message | ||
if: github.event.issue.state_reason == 'completed' | ||
uses: mui/mui-public/.github/workflows/reusable/add-closing-message-to-issue.yml@04275a99fe10cee127ee417b8a872cfebc7d08e7 | ||
permissions: | ||
contents: read | ||
issues: write |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what needed to be checked, nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should roll this change to all the other repositories, right? I imagine it's about https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/.
I'm also not sure how to feel about not asking for support feedback on an issue we closed as not planned. I guess it makes sense, what we would get is mostly people not happy 😄. Kind of https://www.oesterlund.dev/blog/learnings-from-one-year-of-building-an-open-source-project#learning-2-dont-even-try-to-please-everyone, built a system that makes us default to not try to please everyone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the plan is to roll this out to all repos that have at least some user visibility.