-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Update supported Node.js version to 14 #43315
Conversation
Nice catch. Maybe we can update
edit: nevermind, you already pushed a commit addressing it 🦸♂️ |
Netlify deploy previewBundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jan!
@aarongarciah Making a few changes to fix the errors introduced in #43290 and prevent them in the future. cc @JCQuintas this is why I push back against running ci conditionally. So easy to break, especially when it's manually maintained. edit: removing the fix again, it's handled by #43316 |
I don't see where the issue was with the CI itself? I guess it was a typescript issue? I don't think it is inherently bad. If we always run all the CI we can get cost issues or time issues. If we optimise for running only in very specific scenarios we run the chance of making them brittle. Each case is a different case. So we should always take them into account when making decisions. |
It looks like these were forgotten in #42920? This would allow us to add package
"exports"
on a minor.