Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Pin eslint-plugin-jsx-a11y version to 6.7.1 #43292

Merged
merged 8 commits into from
Aug 16, 2024
Merged

[core] Pin eslint-plugin-jsx-a11y version to 6.7.1 #43292

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
83c14c6
Update eslint-plugin-jsx-a11y
Janpot Aug 14, 2024
e92ef0e
Update pnpm-lock.yaml
Janpot Aug 14, 2024
21bbf58
revert table
Janpot Aug 14, 2024
d97a02d
revert more
Janpot Aug 14, 2024
53073e3
ignore
Janpot Aug 14, 2024
fc38c46
Update .eslintrc.js
Janpot Aug 14, 2024
f2de3dc
pin
Janpot Aug 14, 2024
b387a72
Update pnpm-lock.yaml
Janpot Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/data/joy/components/table/TableSortAndSelection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ function EnhancedTableHead(props) {
return (
<thead>
<tr>
<th>
<th aria-label="select all desserts">
<Checkbox
indeterminate={numSelected > 0 && numSelected < rowCount}
checked={rowCount > 0 && numSelected === rowCount}
Expand Down Expand Up @@ -352,7 +352,7 @@ export default function TableSortAndSelection() {
: {}
}
>
<th scope="row">
<th scope="row" aria-labelledby={labelId}>
<Checkbox
checked={isItemSelected}
slotProps={{
Expand Down
4 changes: 2 additions & 2 deletions docs/data/joy/components/table/TableSortAndSelection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ function EnhancedTableHead(props: EnhancedTableProps) {
return (
<thead>
<tr>
<th>
<th aria-label="select all desserts">
<Checkbox
indeterminate={numSelected > 0 && numSelected < rowCount}
checked={rowCount > 0 && numSelected === rowCount}
Expand Down Expand Up @@ -392,7 +392,7 @@ export default function TableSortAndSelection() {
: {}
}
>
<th scope="row">
<th scope="row" aria-labelledby={labelId}>
<Checkbox
checked={isItemSelected}
slotProps={{
Expand Down
7 changes: 5 additions & 2 deletions docs/data/joy/getting-started/templates/order-dashboard/components/OrderTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,10 @@ export default function OrderTable() {
>
<thead>
<tr>
<th style={{ width: 48, textAlign: 'center', padding: '12px 6px' }}>
<th
style={{ width: 48, textAlign: 'center', padding: '12px 6px' }}
aria-label="Selected"
>
<Checkbox
size="sm"
indeterminate={
Expand Down Expand Up @@ -431,7 +434,7 @@ export default function OrderTable() {
<th style={{ width: 140, padding: '12px 6px' }}>Date</th>
<th style={{ width: 140, padding: '12px 6px' }}>Status</th>
<th style={{ width: 240, padding: '12px 6px' }}>Customer</th>
<th style={{ width: 140, padding: '12px 6px' }}> </th>
<th style={{ width: 140, padding: '12px 6px' }} aria-label="Actions" />
</tr>
</thead>
<tbody>
Expand Down
6 changes: 5 additions & 1 deletion docs/src/modules/components/ApiPage/list/ExpandableApiItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,9 @@ export default function ExpandableApiItem(props: ExpandableApiItemProps) {
React.useEffect(() => {
setIsExtended(displayOption === 'expanded');
}, [displayOption]);

const anchorLabelId = React.useId();

return (
<Root
ownerState={{ type }}
Expand All @@ -189,12 +192,13 @@ export default function ExpandableApiItem(props: ExpandableApiItemProps) {
)}
>
<div className="MuiApi-item-header">
<a className="MuiApi-item-link-visual" href={`#${id}`}>
<a className="MuiApi-item-link-visual" href={`#${id}`} aria-labelledby={anchorLabelId}>
<svg>
<use xlinkHref="#anchor-link-icon" />
</svg>
</a>
<span
id={anchorLabelId}
className="MuiApi-item-title algolia-lvl3" // This className is used by Algolia
>
{title}
Expand Down
4 changes: 2 additions & 2 deletions docs/src/modules/components/ApiPage/list/PropertiesList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,12 +157,12 @@ export default function PropertiesList(props: PropertiesListProps) {
<React.Fragment>
{propName}
{isProPlan && (
<a href="/x/introduction/licensing/#pro-plan">
<a href="/x/introduction/licensing/#pro-plan" aria-label="Pro plan">
<span className="plan-pro" />
</a>
)}
{isPremiumPlan && (
<a href="/x/introduction/licensing/#premium-plan">
<a href="/x/introduction/licensing/#premium-plan" aria-label="Premium plan">
<span className="plan-premium" />
</a>
)}
Expand Down
4 changes: 2 additions & 2 deletions docs/src/modules/components/ApiPage/table/PropertiesTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,12 +168,12 @@ export default function PropertiesTable(props: PropertiesTableProps) {
{isRequired ? '*' : ''}
{isOptional ? '?' : ''}
{isProPlan && (
<a href="/x/introduction/licensing/#pro-plan">
<a href="/x/introduction/licensing/#pro-plan" aria-label="Pro plan">
<span className="plan-pro" />
</a>
)}
{isPremiumPlan && (
<a href="/x/introduction/licensing/#premium-plan">
<a href="/x/introduction/licensing/#premium-plan" aria-label="Premium plan">
<span className="plan-premium" />
</a>
)}
Expand Down
2 changes: 1 addition & 1 deletion docs/src/modules/components/MaterialShowcase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ export default function Showcase() {
}),
})}
>
<a href={app.link} rel="noopener nofollow" target="_blank">
<a href={app.link} rel="noopener nofollow" target="_blank" aria-label={app.title}>
<CardMedia
component="img"
loading="lazy"
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@
"eslint-plugin-babel": "^5.3.1",
"eslint-plugin-filenames": "^1.3.2",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-jsx-a11y": "^6.7.1",
"eslint-plugin-jsx-a11y": "^6.9.0",
"eslint-plugin-material-ui": "workspace:^",
"eslint-plugin-mocha": "^10.5.0",
"eslint-plugin-react": "^7.35.0",
Expand Down
Loading