Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Add material-ui-pigment-css for Next.js and Vite #43065
[examples] Add material-ui-pigment-css for Next.js and Vite #43065
Changes from 5 commits
26c3170
86ae467
347a7bf
50d553c
c368a84
eda986f
4b529ed
0d62590
fd5a346
2dd5d78
23a3dea
8015bf5
a22bc48
93745bd
1362963
0b2369d
a34cc41
3e65c26
82a6505
1c4a562
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 1 in examples/material-ui-pigment-css-nextjs-ts/README.md
GitHub Actions / runner / vale
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this accurate? Wouldn't Pigment also extract styles from
styled
,css
,sx
even if they're non-Material UI components?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's accurate, my intention is to point out the integration. We can add more to cover your point, what do you have in mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the current wording some developers might get confused and think that Pigment CSS only works for Material UI components.
Check failure on line 1 in examples/material-ui-pigment-css-vite-ts/README.md
GitHub Actions / runner / vale
Check failure on line 32 in examples/material-ui-pigment-css-vite-ts/README.md
GitHub Actions / runner / vale