-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Fix broken sandboxes with relative module imports #42767
Conversation
Netlify deploy previewhttps://deploy-preview-42767--material-ui.netlify.app/ Bundle size report |
Co-authored-by: Olivier Tassinari <[email protected]> Signed-off-by: Bharat Kashyap <[email protected]>
@bharatkashyap I created #43145 fro mexperimental purpose. My concern with the current solution is that you take into consideration that imports are from For example the tree-view is looking to define 2 or 3 datasets to reuse every where. So they would likely have path like In the PR, I propose to respect the file splitting in the generated codesandbox, but move all the files at the same level. |
Thanks @alexfauquette for this! Your proposal makes sense to me; thanks for bringing to light this oversight :) |
I've replace the package-lock by the current one The demo seems to work nice on both codesandbox and stackblitz 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it with a multi-tab MUI X demo in mui/mui-x#13695 – it works like a charm!
Great job! 🎉
Fixes #42733
The fixed sandbox: https://codesandbox.io/s/late-dream-z36sph?file=/src/Demo.tsx.
Preview: https://deploy-preview-42767--material-ui.netlify.app/material-ui/react-autocomplete/