[material-ui][TextField] Fix ownerState silent propagation #42345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoAndai
added
package: material-ui
Netlify deploy previewhttps://deploy-preview-42345--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
|
See Argos "failures" for further fixes 😅 |
mnajdova
reviewed
May 23, 2024
| @@ -287,6 +287,9 @@ const FilledInput = React.forwardRef(function FilledInput(inProps, ref) { | |||
| type, | |||
| }; | |||
|
|
|||
| // https://github.com/mui/material-ui/issues/42184 | |||
| delete ownerState.ownerState; | |||
There was a problem hiding this comment.
As the issue comes from
, should we maybe handle it there instead? Intercept ifownerState.ownerState exists and remove it? I can't find any use-case when we would want to have it.
|
Closed in favor of #42358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a symptom of #42184. Fixes #42391
Introduced due to #42001 and #42062 being merged in parallel without testing them together. I think this is why Argos didn't catch it.
Bug
https://next.mui.com/material-ui/react-text-field/
Fix
PR preview: Waiting for PR deploy
Benchmark: https://mui.com/material-ui/react-text-field/
Notes
The TextField's intricate
ownerStatescheme is hard to track and maintain. There are probably bugs similar to these that we didn't catch.