Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blog] Introducing Pigment CSS blog post #42198
[blog] Introducing Pigment CSS blog post #42198
Changes from all commits
e6b7ba7
028eff7
5909f0c
a522128
cc8681f
accf09b
c145800
702d8ae
e41dc62
c25dfdb
db5806b
f4eb4f7
4c01719
215673e
f661b38
7c4699b
7396c50
3712171
89042b8
0325259
a6a356d
e86ebf9
48a33f3
b8696f0
c865606
1271247
d14d96d
55ab13e
56cf3c9
00c43f7
41674b8
fb0abde
cbcbe7f
11c2151
4ba9aaf
9a9e884
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 12 in docs/pages/blog/introducing-pigment-css.md
GitHub Actions / runner / vale
Check warning on line 12 in docs/pages/blog/introducing-pigment-css.md
GitHub Actions / runner / vale
Check warning on line 13 in docs/pages/blog/introducing-pigment-css.md
GitHub Actions / runner / vale
Check warning on line 23 in docs/pages/blog/introducing-pigment-css.md
GitHub Actions / runner / vale
Check warning on line 32 in docs/pages/blog/introducing-pigment-css.md
GitHub Actions / runner / vale
Check warning on line 32 in docs/pages/blog/introducing-pigment-css.md
GitHub Actions / runner / vale
Check warning on line 32 in docs/pages/blog/introducing-pigment-css.md
GitHub Actions / runner / vale
Check warning on line 33 in docs/pages/blog/introducing-pigment-css.md
GitHub Actions / runner / vale
Check warning on line 36 in docs/pages/blog/introducing-pigment-css.md
GitHub Actions / runner / vale
Check warning on line 45 in docs/pages/blog/introducing-pigment-css.md
GitHub Actions / runner / vale
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't feel accurate. I have reworked this part in https://react-conf-2024-pigment-css.netlify.app/?presenterMode=true&slideIndex=29&stepIndex=0. The first point is that Atomic for production, sure, if it helps with performance, great. The issue with atomic classes is only in development mode IMHO. I have doubt that https://twitter.com/astahmer_dev/status/1776919737999425629 can truly help here.
My point is that "Other options don't meet our needs", yes, but a big part of this is that we also see an opportunity with a deeper bundle integration, that we don't see any other library trying. Mostly because it's a lot of work, but hopefully: 1. we have the resources to make it work, and 2. React Compiler is paving the way
Two examples of projects not trying/giving up on this direction:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm lost by this section.
These seem to be load time performance, which I believe is not the same as runtime performance. So I would start with:
and then add a new header for render performance specifically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like we link a benchmark about "runtime" to support praise on performance improvement for "page load" time. It doesn't make sense to me. I think we need to fix this for this section to have technical credibility with the community.