Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui] Add missing backticks to HTML tag in the installation page #41972

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Conversation

Miguelrom
Copy link
Contributor

@Miguelrom Miguelrom commented Apr 20, 2024

Backticks were added around the HTML tag to render it as code.
Without it the tag just does not render.

@mui-bot
Copy link

mui-bot commented Apr 20, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against daedcbe

@danilo-leal danilo-leal changed the title [MUI core] [Docs] Add missing backticks to HTML tag [material-ui][docs] Add missing backticks to HTML tag in the installation page Apr 20, 2024
@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Apr 20, 2024
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Appreciate it!

Can I ask for you to point this PR to the next branch instead, though? You might need to rebase it so you maintain in the PR only the changed file.

@Miguelrom Miguelrom changed the base branch from master to next April 21, 2024 22:48
@Miguelrom Miguelrom changed the base branch from next to master April 21, 2024 23:28
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 22, 2024
@Miguelrom Miguelrom changed the base branch from master to next April 22, 2024 01:50
@Miguelrom
Copy link
Contributor Author

I'm not sure if I did this correctly.

I basically rebased locally, forced pushed the branch to my fork and then changed from master to next in the PR.

If this doesn't work, no big deal. I'll try again some other day by making the change in the next branch.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 22, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][docs] Add missing backticks to HTML tag in the installation page [docs][material-ui] Add missing backticks to HTML tag in the installation page Apr 23, 2024
@ZeeshanTamboli ZeeshanTamboli added the needs cherry-pick The PR should be cherry-picked to master after merge label Apr 23, 2024
@ZeeshanTamboli ZeeshanTamboli merged commit 61e3f76 into mui:next Apr 23, 2024
20 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
…tion page (#41972)

Signed-off-by: Miguel Romero <[email protected]>
Co-authored-by: ZeeshanTamboli <[email protected]>
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Apr 24, 2024
…tion page (mui#41972)

Signed-off-by: Miguel Romero <[email protected]>
Co-authored-by: ZeeshanTamboli <[email protected]>
@Miguelrom Miguelrom deleted the patch-1 branch April 29, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants