-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][docs] Simplify components styling on templates #41845
Merged
zanivan
merged 9 commits into
mui:next
from
zanivan:material-ui-template-styled-components
Apr 16, 2024
Merged
[material-ui][docs] Simplify components styling on templates #41845
zanivan
merged 9 commits into
mui:next
from
zanivan:material-ui-template-styled-components
Apr 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanivan
added
docs
Improvements or additions to the documentation
package: material-ui
Specific to @mui/material
design
This is about UI or UX design, please involve a designer
labels
Apr 10, 2024
Netlify deploy previewhttps://deploy-preview-41845--material-ui.netlify.app/ Bundle size report |
danilo-leal
reviewed
Apr 11, 2024
docs/data/material/getting-started/templates/checkout/PaymentForm.js
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/landing-page/components/Hero.js
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/SignInCard.js
Outdated
Show resolved
Hide resolved
28 tasks
danilo-leal
reviewed
Apr 12, 2024
docs/data/material/getting-started/templates/checkout/PaymentForm.js
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/landing-page/components/Features.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
danilo-leal
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last few remarks — the rest look solid!
docs/data/material/getting-started/templates/checkout/PaymentForm.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/PaymentForm.js
Outdated
Show resolved
Hide resolved
|
||
const SignInContainer = styled(Stack)(({ theme }) => ({ | ||
height: 'auto', | ||
padingBottom: theme.spacing(12), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
padingBottom: theme.spacing(12), | |
paddingBottom: theme.spacing(12), |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
This is about UI or UX design, please involve a designer
docs
Improvements or additions to the documentation
package: material-ui
Specific to @mui/material
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for turning the heavy styled components into
StyledComponents
instead of usingsx
prop on the free Material UI templates.