Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Autocomplete] Display options provided to the options prop even if loading is true. #41634

Merged
merged 10 commits into from
Mar 25, 2024
Merged

[material-ui][Autocomplete] Display options provided to the options prop even if loading is true. #41634

merged 10 commits into from
Mar 25, 2024

Conversation

nekoya
Copy link
Contributor

@nekoya nekoya commented Mar 25, 2024 •
edited by ZeeshanTamboli
Loading

fix #41633

Display loading message even if the options exist.

mnajdova and others added 6 commits March 20, 2024 09:11
@ZeeshanTamboli ZeeshanTamboli changed the base branch from master to next March 25, 2024 11:11
@mui-bot
Copy link

mui-bot commented Mar 25, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41634--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against e764cee

@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work package: material-ui Specific to @mui/material component: autocomplete This is the name of the generic UI component, not the React module! regression A bug, but worse labels Mar 25, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][Autocomplete] Fix handling of loading state with non-empty options [material-ui][Autocomplete] Show options passed to options prop even if loading Mar 25, 2024
ZeeshanTamboli
ZeeshanTamboli approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nekoya Thank you for the PR. I've made the necessary changes. See why here: #41633 (comment).

Since we're pushing changes to the next branch, I've updated the base branch to next.

Regarding when the loading state should be displayed, let's discuss it in a separate issue. For now, I've reverted to the previous change from before #41300.

@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][Autocomplete] Show options passed to options prop even if loading [material-ui][Autocomplete] Display options provided to the options prop even if loading is true. Mar 25, 2024
@ZeeshanTamboli ZeeshanTamboli merged commit 31d5291 into mui:next Mar 25, 2024
19 checks passed
@michaldudak michaldudak mentioned this pull request Mar 25, 2024
Open
4 tasks
@mnajdova
Copy link
Member

@ZeeshanTamboli please make sure that fixes, especially regressions are covered with tests, otherwise we have no guarantee that this will not break again.

@mnajdova mnajdova added the PR: needs test The pull request can't be merged label Mar 25, 2024
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Mar 27, 2024
Merged
1 task
@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Mar 27, 2024 •
edited
Loading

@ZeeshanTamboli please make sure that fixes, especially regressions are covered with tests, otherwise we have no guarantee that this will not break again.

Apologies. Created a PR for adding a test: #41675.

@ZeeshanTamboli ZeeshanTamboli removed the PR: needs test The pull request can't be merged label Mar 27, 2024
ZeeshanTamboli added a commit to ZeeshanTamboli/material-ui that referenced this pull request Mar 27, 2024
@nekoya @ZeeshanTamboli
[material-ui][Autocomplete] Display options provided to the options…
9a66cdb 
… prop even if loading is true. (mui#41634)

Co-authored-by: ZeeshanTamboli <[email protected]>
@nekoya
Copy link
Contributor Author

nekoya commented Apr 2, 2024

@ZeeshanTamboli @mnajdova Thanks for merging. Could this fix be applied to v5 as well? Is there a plan to backport it?

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Apr 2, 2024 •
edited
Loading

@nekoya Here's the PR that should be merged for v5: #41677.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[material-ui][Autocomplete] broke backward compatibility with loading state
6 participants
@nekoya @mui-bot @mnajdova @ZeeshanTamboli @danilo-leal @cherniavskii