[core] Update browser support versions #41568

siriwatknp · 2024-03-20T03:55:34Z

I started to work on this because of [material-ui][Button] Convert to support CSS extraction #41378
Run npx browserslist --mobile-to-desktop "> 0.2%, last 2 versions, Firefox ESR, not dead"
~~Remove legacy since we no longer support IE~~ move to the next PR
Update node version from npx browserslist "maintained node versions"

I have followed (at least) the PR section of the contributing guide.

mui-bot · 2024-03-20T03:58:06Z

Netlify deploy preview

docs/data/material/getting-started/supported-platforms/supported-platforms.md

@material-ui/core: parsed: -1.08% 😍, gzip: -1.35% 😍
@material-ui/lab: parsed: -0.90% 😍, gzip: -1.14% 😍
@material-ui/system: parsed: -0.90% 😍, gzip: -0.90% 😍
@material-ui/unstyled: parsed: -2.88% 😍, gzip: -2.47% 😍
@mui/joy: parsed: -2.60% 😍, gzip: -2.98% 😍

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against c73c022

Janpot · 2024-03-20T04:10:06Z

There is also a "legacy" env in the babel config

material-ui/babel.config.js

Line 16 in f6a89c1

    
           const useESModules = api.env(['regressions', 'legacy', 'modern', 'stable', 'rollup']);

siriwatknp · 2024-03-20T07:15:24Z

Checking it again, I found several places related to IE11 to remove and I am afraid that this PR might be too big to review, so I will bring the legacy back and split the PR.

…rslist-update

michaldudak · 2024-03-20T07:41:12Z

.browserslistrc

-opera 76
-safari 14
-samsung 13.0
+op_mob 73 # The op_mob 80 is unknown, so downgrading to 73


It does work in Base UI: https://github.com/mui/base-ui/blob/master/.browserslistrc
Have you tried updating caniuse-lite to the latest version?

@michaldudak It really because of caniuse-lite. However, I don't see any usage of "caniuse-lite" in any of the package.json, so I make it work with pnpm up "caniuse-lite". Is it the correct way to upgrade implicit deps? cc @Janpot

Is it the correct way to upgrade implicit deps?

👍 Probably also want to run pnpm dedupe after. But I see no problem with this.

@siriwatknp Actually, it seems to be

npx browserslist@latest --update-db

DiegoAndai · 2024-03-20T12:49:34Z

.browserslistrc

+safari 17.4
+safari 17.3
+safari 17.2


We agreed upon Safari 15.4 for v6 at #40958 (comment)

Thanks for pointing that out. Will update it. cc @michaldudak Would you like to use the same list for Base UI?

We'll decide when it's closer to our release. Thanks for letting me know.

Janpot · 2024-03-20T16:47:14Z

@siriwatknp Regarding node.js upgrade, have you seen the debates in mui/mui-x#10997 and #32546?

siriwatknp · 2024-03-21T07:40:37Z

@siriwatknp Regarding node.js upgrade, have you seen the debates in mui/mui-x#10997 and #32546?

Thanks, I will remove nodejs update from this PR.

…rslist-update

Janpot

Looks good. Last suggestion: If it makes sense, add a package.json script for updating the browserslist. And an instruction in the .browserslistrc file to run the script on major versions?

"update-browserslist": "browserslist@latest --update-db && browserslist@latest --mobile-to-desktop \"> 0.2%, last 2 versions, Firefox ESR, not dead\""

LukasTy · 2024-03-21T09:22:01Z

Looks good. Last suggestion: If it makes sense, add a package.json script for updating the browserslist. And an instruction in the .browserslistrc file to run the script on major versions?

@Janpot I'm not sure if this is better. 🤔
There is no easy way to leave comments in package.json and in this case, we have a custom decision for Safari support.
IMHO, the current solution is a bit more flexible.
Adding it to the major release instruction guide makes sense in any case, we can refer to the browserlisrc file and link a reference PR/issue. 👌

Janpot · 2024-03-21T09:37:54Z

Fair enough. Some release instructions makes sense as well. Maybe it makes sense to mention the browserslist@latest --update-db command?

LukasTy · 2024-03-21T09:43:21Z

Fair enough. Some release instructions makes sense as well. Maybe it makes sense to mention the browserslist@latest --update-db command?

Oh yes, that makes sense. I've done it manually by removing the lock entry and rerunning the install. 🙈 😆
BTW, your example probably misses the npx at the start, because we do not list browserslist as a direct dependency. 🤔

DiegoAndai

Small fix on the documentation. Otherwise LGTM 👍🏼

docs/data/material/getting-started/supported-platforms/supported-platforms.md

siriwatknp · 2024-03-22T04:00:03Z

Fair enough. Some release instructions makes sense as well. Maybe it makes sense to mention the browserslist@latest --update-db command?

Added a note to run npx update-browserslist-db@latest after updating the browser versions. browserslist@latest --update-db is deprecated.

…ui into browserslist-update

siriwatknp added 2 commits March 20, 2024 10:53

update browserslist and remove 'legacy'

ebfa438

update engines to the supported node version

e103fe2

siriwatknp added breaking change v6.x labels Mar 20, 2024

siriwatknp requested review from a team March 20, 2024 03:56

siriwatknp added 3 commits March 20, 2024 14:15

Merge branch 'next' of https://github.com/mui/material-ui into browse…

1571298

…rslist-update

bring back legacy

6b53057

update node engines

fa789ca

michaldudak reviewed Mar 20, 2024

View reviewed changes

siriwatknp added 7 commits March 20, 2024 15:07

update caniuse-lite

a25b3b0

use the same as base-ui

251881a

update next to 13.5.6 to update caniuse-lite

7854fd0

restore

5b3c20d

use caret

d180676

revert nextjs

179c6c4

update next

b8620ac

danilo-leal changed the title ~~Update browser support versions~~ [core] Update browser support versions Mar 20, 2024

danilo-leal added the core Infrastructure work going on behind the scenes label Mar 20, 2024

DiegoAndai reviewed Mar 20, 2024

View reviewed changes

LukasTy mentioned this pull request Mar 20, 2024

[core] Update supported browsers (browserslistrc) mui/mui-x#12521

Merged

siriwatknp added 4 commits March 21, 2024 15:52

Merge branch 'next' of https://github.com/mui/material-ui into browse…

2d2b4cc

…rslist-update

revert node update

5bf4343

update browsers support and revert nodejs

99a5a8b

npx browserslist@latest --update-db

69d9b60

siriwatknp requested review from Janpot and DiegoAndai March 21, 2024 09:00

Janpot approved these changes Mar 21, 2024

View reviewed changes

DiegoAndai approved these changes Mar 21, 2024

View reviewed changes

docs/data/material/getting-started/supported-platforms/supported-platforms.md Outdated Show resolved Hide resolved

oliviertassinari mentioned this pull request Mar 21, 2024

[TextareaAutosize] Deprecate TextareaAutosize #43720

Open

update docs

10470ba

Merge branch 'browserslist-update' of github.com:siriwatknp/material-…

c73c022

…ui into browserslist-update

siriwatknp enabled auto-merge (squash) March 22, 2024 04:02

siriwatknp merged commit aff8f32 into mui:next Mar 22, 2024
21 checks passed

ZeeshanTamboli mentioned this pull request Mar 25, 2024

[docs] Drop IE 11 official support #41611

Merged

ZeeshanTamboli mentioned this pull request May 6, 2024

[material-ui] Update browser supports in v6 #40958

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core] Update browser support versions #41568

[core] Update browser support versions #41568

siriwatknp commented Mar 20, 2024 •

edited by oliviertassinari

Loading

mui-bot commented Mar 20, 2024 •

edited

Loading

Janpot commented Mar 20, 2024

siriwatknp commented Mar 20, 2024

michaldudak Mar 20, 2024

siriwatknp Mar 20, 2024

siriwatknp Mar 20, 2024

Janpot Mar 20, 2024

Janpot Mar 20, 2024 •

edited

Loading

DiegoAndai Mar 20, 2024

siriwatknp Mar 20, 2024

michaldudak Mar 20, 2024

Janpot commented Mar 20, 2024

siriwatknp commented Mar 21, 2024

Janpot left a comment

LukasTy commented Mar 21, 2024

Janpot commented Mar 21, 2024

LukasTy commented Mar 21, 2024

DiegoAndai left a comment

siriwatknp commented Mar 22, 2024

[core] Update browser support versions #41568

[core] Update browser support versions #41568

Conversation

siriwatknp commented Mar 20, 2024 • edited by oliviertassinari Loading

mui-bot commented Mar 20, 2024 • edited Loading

Netlify deploy preview

Bundle size report

Janpot commented Mar 20, 2024

siriwatknp commented Mar 20, 2024

michaldudak Mar 20, 2024

Choose a reason for hiding this comment

siriwatknp Mar 20, 2024

Choose a reason for hiding this comment

siriwatknp Mar 20, 2024

Choose a reason for hiding this comment

Janpot Mar 20, 2024

Choose a reason for hiding this comment

Janpot Mar 20, 2024 • edited Loading

Choose a reason for hiding this comment

DiegoAndai Mar 20, 2024

Choose a reason for hiding this comment

siriwatknp Mar 20, 2024

Choose a reason for hiding this comment

michaldudak Mar 20, 2024

Choose a reason for hiding this comment

Janpot commented Mar 20, 2024

siriwatknp commented Mar 21, 2024

Janpot left a comment

Choose a reason for hiding this comment

LukasTy commented Mar 21, 2024

Janpot commented Mar 21, 2024

LukasTy commented Mar 21, 2024

DiegoAndai left a comment

Choose a reason for hiding this comment

siriwatknp commented Mar 22, 2024

siriwatknp commented Mar 20, 2024 •

edited by oliviertassinari

Loading

mui-bot commented Mar 20, 2024 •

edited

Loading

Janpot Mar 20, 2024 •

edited

Loading