Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][joy-ui] Remove unnecessary styles in color inversion footer demo #41419

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

cipherlogs
Copy link
Contributor

To make it easier for future readers and reduce any potential confusion.

  1. --ListItem-gap: Since every list item only has one child, the gap isn't needed at all.
  2. --ListItemDecorator-size: got rid of this style because no decorator was used, and it’s not needed.

1. `--ListItem-gap`: removed the gap for each list item. Since every list item only has one child, the gap isn’t useless.
2. `--ListItemDecorator-size`: got rid of this style because no decorator was used, and it’s not needed.
@mui-bot
Copy link

mui-bot commented Mar 9, 2024

Netlify deploy preview

https://deploy-preview-41419--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 49106a4

@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work package: joy-ui Specific to @mui/joy docs Improvements or additions to the documentation labels Mar 10, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [joy-ui][docs] Remove Unnecessary Styles [docs][joy-ui] Remove Unnecessary Styles in color inversion footer demo Mar 10, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][joy-ui] Remove Unnecessary Styles in color inversion footer demo [docs][joy-ui] Remove unnecessary styles in color inversion footer demo Mar 10, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ZeeshanTamboli ZeeshanTamboli merged commit b3e0b43 into mui:master Mar 10, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants