-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][joy-ui] Remove unnecessary styles in color inversion footer demo #41419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. `--ListItem-gap`: removed the gap for each list item. Since every list item only has one child, the gap isn’t useless. 2. `--ListItemDecorator-size`: got rid of this style because no decorator was used, and it’s not needed.
Netlify deploy previewhttps://deploy-preview-41419--material-ui.netlify.app/ Bundle size report |
ZeeshanTamboli
added
bug 🐛
Something doesn't work
package: joy-ui
Specific to @mui/joy
docs
Improvements or additions to the documentation
labels
Mar 10, 2024
ZeeshanTamboli
changed the title
[joy-ui][docs] Remove Unnecessary Styles
[docs][joy-ui] Remove Unnecessary Styles in color inversion footer demo
Mar 10, 2024
ZeeshanTamboli
changed the title
[docs][joy-ui] Remove Unnecessary Styles in color inversion footer demo
[docs][joy-ui] Remove unnecessary styles in color inversion footer demo
Mar 10, 2024
ZeeshanTamboli
approved these changes
Mar 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This was referenced May 19, 2024
This was referenced May 20, 2024
This was referenced May 21, 2024
This was referenced Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
docs
Improvements or additions to the documentation
package: joy-ui
Specific to @mui/joy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier for future readers and reduce any potential confusion.
--ListItem-gap
: Since every list item only has one child, the gap isn't needed at all.--ListItemDecorator-size
: got rid of this style because no decorator was used, and it’s not needed.