Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy-ui][docs] Remove wrong CSS prop from the Sign-in-side template #41383

Merged
merged 8 commits into from
Mar 8, 2024

Commits on Mar 6, 2024

  1. [joy-ui][docs] Remove wrong css prop

    The term align-items: left doesn’t exist and also There’s no need to worry about cross axis alignment because there’s no extra height. So, you can remove it from the code without any issues.
    
    Signed-off-by: Nedal <[email protected]>
    cipherlogs authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    69d74f9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    41423bb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7c4a173 View commit details
    Browse the repository at this point in the history
  4. [joy-ui][docs] Fix divider visibility issue on light-mode

    When using light mode, there’s an issue between the `769px` and `900px` width range. During this range, the divider is not visible. I recommend removing the collapsing breakpoint altogether and relying solely on the defaul `md` value
    breakpoint.
    cipherlogs committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    09aa7e6 View commit details
    Browse the repository at this point in the history
  5. [joy-ui][docs] Refactor FormLabel asterisks visibility

    There's no need for an extra import, we can use the class name directly to target all asterisk slots
    withing the form container.
    cipherlogs committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    d9ff4a3 View commit details
    Browse the repository at this point in the history
  6. [joy-ui][docs] Simplify ColorSchemeToggle()

    Better provide a meaningful feedback to users and screen readers, regardless of whether the component is mounted or not. Here are the changes made:
    
    1. When component isn't mounted
      + an aria-label and a default icon will be provided for better context.
      + the button will be disabled
      + `onClick` will be attached, but it won't be invoked because the button is disabled
    
    2. When component is mounted
      + The user will be able to toggle the color scheme as expected
    cipherlogs committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    d4e4355 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    dc4237d View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Configuration menu
    Copy the full SHA
    7f3bd71 View commit details
    Browse the repository at this point in the history