-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[joy-ui][docs] Remove wrong CSS prop from the Sign-in-side template #41383
Merged
Commits on Mar 6, 2024
-
[joy-ui][docs] Remove wrong css prop
The term align-items: left doesn’t exist and also There’s no need to worry about cross axis alignment because there’s no extra height. So, you can remove it from the code without any issues. Signed-off-by: Nedal <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 69d74f9 - Browse repository at this point
Copy the full SHA 69d74f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41423bb - Browse repository at this point
Copy the full SHA 41423bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c4a173 - Browse repository at this point
Copy the full SHA 7c4a173View commit details -
[joy-ui][docs] Fix divider visibility issue on light-mode
When using light mode, there’s an issue between the `769px` and `900px` width range. During this range, the divider is not visible. I recommend removing the collapsing breakpoint altogether and relying solely on the defaul `md` value breakpoint.
Configuration menu - View commit details
-
Copy full SHA for 09aa7e6 - Browse repository at this point
Copy the full SHA 09aa7e6View commit details -
[joy-ui][docs] Refactor FormLabel asterisks visibility
There's no need for an extra import, we can use the class name directly to target all asterisk slots withing the form container.
Configuration menu - View commit details
-
Copy full SHA for d9ff4a3 - Browse repository at this point
Copy the full SHA d9ff4a3View commit details -
[joy-ui][docs] Simplify ColorSchemeToggle()
Better provide a meaningful feedback to users and screen readers, regardless of whether the component is mounted or not. Here are the changes made: 1. When component isn't mounted + an aria-label and a default icon will be provided for better context. + the button will be disabled + `onClick` will be attached, but it won't be invoked because the button is disabled 2. When component is mounted + The user will be able to toggle the color scheme as expected
Configuration menu - View commit details
-
Copy full SHA for d4e4355 - Browse repository at this point
Copy the full SHA d4e4355View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc4237d - Browse repository at this point
Copy the full SHA dc4237dView commit details
Commits on Mar 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7f3bd71 - Browse repository at this point
Copy the full SHA 7f3bd71View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.