[Buttons] Fixed alignment related regressions #4130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 38.83%@@ master #4130 diff @@
==========================================
Files 137 137
Lines 4381 4381
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1701 1701
Misses 2680 2680
Partials 0 0
|
|
@nathanmarks I have also identified the line-height as the pain point. That looks good. Thanks 👍. |
|
@oliviertassinari yep, the outer line height in snack bar was affecting the button. PS, check collab chat RE the codecov spam |
This was referenced Jan 12, 2022
This was referenced Mar 20, 2022
zannager
added
the
component: button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@oliviertassinari
I've reduced the # of line-height props within the buttons and made it work properly with line-height at the button node by changing the
font: 'inherit'prop inEnhancedButton.If we have more problems with this I suggest we consider switching the component to flexbox sooner rather than later.