[EnhancedButton] Fix keyboard focus jumping #4127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -210,6 +210,7 @@ class EnhancedButton extends Component { | |||
| this.focusTimeout = setTimeout(() => { | |||
| if (tabPressed) { | |||
| this.setKeyboardFocus(event); | |||
| tabPressed = false; | |||
There was a problem hiding this comment.
This is the actual bug fix.
It was possible to move keyboard focus using the mouse by keyboard focussing on a button, clicking on another button, holding, and moving the mosue away. Also fixes a state naming issue in RaisedButton, and some code style issues.
|
@mbrookes thanks for fixing this! 😄 works great now |
|
That was an ugly bug 🎉. @mbrookes Nice! |
This was referenced Jan 12, 2022
This was referenced Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests /docs demo, and is linted.It was possible to move keyboard focus using the mouse by keyboard focussing
on a button, clicking on another button, holding, and moving the mosue away.
Also fixes a state naming issue in RaisedButton, and some code style issues.
Fixes #3919