[Slider]: Fix Slider div styles. #4086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| import React, {Component, PropTypes} from 'react'; | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Could you revert this change? See #4058 for more details.
|
@tintin1343 Notice that fixing the issue require to introduce a breaking change. |
oliviertassinari
added
the
PR: needs revision
This fixes a regression that was introduced in mui#3360. The previous `click-awayable` mixin listened on `mouseup` and `touchend` events and the new `ClickAwayListener` was implemented to use `mousedown` and `touchstart` events. This commit changes the events to mimick the behavior from the original mixin. Resolves mui#3818
Adds instructions for installing the @next npm package to the README. Also removed an incorrect line from the installation instructions.
tintin1343
force-pushed
the
slider-style
branch
from
8959423
to
e701ae4
Compare
|
Closing this and deleting the branch as I was having issues with the commit log. Created a new PR #4087 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3282
The issue with the current slider style was that it used to apply styles twice because of the prepareStyles being used and hence the width % was being applied twice.
I removed the prepare styles component and replace it with the inline style class which was being used anyway. So the style will be applied only once to the "root" div.
I only changed two lines though the others where included when I made a pull from the upstream master.