Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Dialog] Add slots to dialog #40687

Closed
wants to merge 23 commits into from

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Jan 19, 2024

part of #40417

what does this PR do

  1. deprecate TransitionProps , TransitionComponent, PaperProps, PaperComponent, transitionDuration
  2. add codemods for above deprecations
  3. add slots and slotProps props
  4. remove deprecated props references from docs

@sai6855 sai6855 marked this pull request as draft January 19, 2024 12:01
@sai6855 sai6855 added component: dialog This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material v6.x labels Jan 19, 2024
@mui-bot
Copy link

mui-bot commented Jan 19, 2024

Netlify deploy preview

https://deploy-preview-40687--material-ui.netlify.app/

@material-ui/core: parsed: +0.08% , gzip: +0.10%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 726108f

@sai6855
Copy link
Contributor Author

sai6855 commented Feb 1, 2024

@DiegoAndai a quick question. Dialog has following props that should be deprecated

TransitionProps , TransitionComponent, PaperProps, PaperComponent, transitionDuration, BackdropComponent, BackdropProps, componentProps, components, onBackdropClick.

out of these above props, deprecation for TransitionProps , TransitionComponent, PaperProps, PaperComponent, transitionDuration, are in this PR.but as you can see this PR has already gotten too big. So shall i deprecated other props in this PR or do it in seperate PR.

@sai6855 sai6855 marked this pull request as ready for review February 1, 2024 16:25
}}
slotProps={{
paper: { className: 'paper' },

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't figure out why new line keep getting added, any help would be appreciated here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, either. Would you know @siriwatknp?

Anyway, this should be covered by the user's formatting rules, as those might differ, and it would be impossible for us to accommodate all linting rules. So I wouldn't care too much until someone complains.

@sai6855 sai6855 marked this pull request as draft February 4, 2024 13:19
@sai6855 sai6855 removed the request for review from DiegoAndai February 4, 2024 13:21
@DiegoAndai
Copy link
Member

[...] out of these above props, deprecation for TransitionProps , TransitionComponent, PaperProps, PaperComponent, transitionDuration, are in this PR.but as you can see this PR has already gotten too big. So shall i deprecated other props in this PR or do it in seperate PR.

Separate PRs seems like a good idea 🙌🏼

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 7, 2024
@sai6855 sai6855 closed this Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dialog This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material PR: out-of-date The pull request has merge conflicts and can't be merged v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants