-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Dialog] Add slots to dialog #40687
Conversation
Netlify deploy previewhttps://deploy-preview-40687--material-ui.netlify.app/ @material-ui/core: parsed: +0.08% , gzip: +0.10% Bundle size reportDetails of bundle changes (Toolpad) |
9adf9e1
to
fca5013
Compare
c5885e9
to
1752730
Compare
@DiegoAndai a quick question. TransitionProps , TransitionComponent, PaperProps, PaperComponent, transitionDuration, BackdropComponent, BackdropProps, componentProps, components, onBackdropClick. out of these above props, deprecation for |
}} | ||
slotProps={{ | ||
paper: { className: 'paper' }, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldn't figure out why new line keep getting added, any help would be appreciated here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, either. Would you know @siriwatknp?
Anyway, this should be covered by the user's formatting rules, as those might differ, and it would be impossible for us to accommodate all linting rules. So I wouldn't care too much until someone complains.
Separate PRs seems like a good idea 🙌🏼 |
part of #40417
what does this PR do