[material-ui][Divider] Deprecate props and composed classes for v6 #40563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
component: divider
Netlify deploy previewhttps://deploy-preview-40563--material-ui.netlify.app/ Bundle size report |
sai6855
commented
Jan 13, 2024
| @@ -257,6 +257,7 @@ Divider.propTypes /* remove-proptypes */ = { | |||
| /** | |||
| * If `true`, the divider will have a lighter color. | |||
| * @default false | |||
| * @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> instead. | |||
There was a problem hiding this comment.
light prop was removed from Divider v7 , so deprecated it.
There was a problem hiding this comment.
Suggested change
| * @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> instead. | |
| * @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> (or any color) instead. |
sai6855
commented
Jan 13, 2024
| @@ -10,7 +10,9 @@ export interface DividerClasses { | |||
| inset: string; | |||
| /** Styles applied to the root element if `variant="fullWidth"`. */ | |||
| fullWidth: string; | |||
| /** Styles applied to the root element if `light={true}`. */ | |||
| /** Styles applied to the root element if `light={true}`. | |||
| * @deprecated | |||
There was a problem hiding this comment.
i'm not sure, what's the alternative way for light class selector. so just left empty as of now
sai6855
changed the title
DiegoAndai
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
LGTM 🚀
Left one suggestion for the light prop deprecation message. Could you apply it and run the docs generation scripts? 😊
For subsequent deprecation PRs, lets do separate PRs:
- One for *Props type props
- One for composed classes
- Separate ones for other props/classes
I'll add a short guide for this this week.
| @@ -257,6 +257,7 @@ Divider.propTypes /* remove-proptypes */ = { | |||
| /** | |||
| * If `true`, the divider will have a lighter color. | |||
| * @default false | |||
| * @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> instead. | |||
There was a problem hiding this comment.
Suggested change
| * @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> instead. | |
| * @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> (or any color) instead. |
|
@DiegoAndai done :) Also can you update this PR in issue description, so that others won't pick up Divider. (I don't have access to do) |
1 task
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of: #40417
preview: https://deploy-preview-40563--material-ui.netlify.app/material-ui/api/divider/