Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lab] Add use client directive #40358

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Dec 29, 2023

Add @mui/lab to the RSC build step and run it for the first time, adding the corresponding 'use client' directives.

Fix #40349

@DiegoAndai DiegoAndai added package: lab Specific to @mui/lab core Infrastructure work going on behind the scenes labels Dec 29, 2023
@DiegoAndai DiegoAndai self-assigned this Dec 29, 2023
@mui-bot
Copy link

mui-bot commented Dec 29, 2023

Netlify deploy preview

https://deploy-preview-40358--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6df98ce

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 29, 2023

Nice 👍


Off-topic

It would be great to remove all the directives from the index files as well, e.g.

It makes it hard to expose server side logic from the npm package, e.g. #42750

@DiegoAndai DiegoAndai merged commit 8837023 into mui:master Jan 2, 2024
22 checks passed
@DiegoAndai DiegoAndai deleted the mui-lab-use-client branch January 2, 2024 14:08
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes nextjs package: lab Specific to @mui/lab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][Timeline] Not working with server-side in an App Router Next.js project
4 participants