-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Remove explicit mui-x
dependency resolving
#40257
Conversation
Netlify deploy previewhttps://deploy-preview-40257--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, this logic will be a lot easier to maintain on our repo
Just, are we sure that we don't have any demo on the core doc that depends on it?
Everything works as expected unless I couldn't find some demo related to Data Grid or Pickers. 🙈 |
mui-x
dependency resolvingmui-x
dependency resolving
I changed the label to be What about this demo though https://mui.com/x/react-date-pickers/getting-started/#render-your-first-component? I guess it's not needed because the dependencies are hardcoded. |
Thanks, in that case, I've asked for a review from
It's the same as for all the other demos. We moved the relevant related dependency resolving into |
Warning This branch should not be deleted, because it is used for v6 (master) and will remain being used for |
mui-x
relevant packages resolving in monorepo relevant codepostProcessImport
"hook", with which mui-x can post-process the import on it's endmui-x
related tests in favour of mui/mui-x@f67a686Needed to resolve time-sensitive issue due to breaking
date-fns
v3 release: mui/mui-x#11463