Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Remove explicit mui-x dependency resolving #40257

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Dec 20, 2023

  • Remove explicit mui-x relevant packages resolving in monorepo relevant code
  • introduce the optional postProcessImport "hook", with which mui-x can post-process the import on it's end
  • Remove mui-x related tests in favour of mui/mui-x@f67a686

Needed to resolve time-sensitive issue due to breaking date-fns v3 release: mui/mui-x#11463

@LukasTy LukasTy added docs Improvements or additions to the documentation core Infrastructure work going on behind the scenes MUI X labels Dec 20, 2023
@LukasTy LukasTy self-assigned this Dec 20, 2023
@mui-bot
Copy link

mui-bot commented Dec 20, 2023

Netlify deploy preview

https://deploy-preview-40257--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 34bb37a

Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, this logic will be a lot easier to maintain on our repo

Just, are we sure that we don't have any demo on the core doc that depends on it?

@LukasTy
Copy link
Member Author

LukasTy commented Dec 21, 2023

Just, are we sure that we don't have any demo on the core doc that depends on it?

Everything works as expected unless I couldn't find some demo related to Data Grid or Pickers. 🙈
There are basically no demos in docs having X dependencies and an option to edit it in codesandbox, hence, nothing seems impacted.
I've reverted one change that could have had the slightest impact, because there is a demo using Data Grid that is editable. 👍

@oliviertassinari oliviertassinari added scope: docs-infra Specific to the docs-infra product and removed docs Improvements or additions to the documentation labels Dec 27, 2023
@oliviertassinari oliviertassinari changed the title [core] Remove explicit mui-x dependency resolving [docs-infra] Remove explicit mui-x dependency resolving Dec 27, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 27, 2023

I changed the label to be docs-infra. This looks about having the proper abstraction level, it was a leaky abstraction before.

What about this demo though https://mui.com/x/react-date-pickers/getting-started/#render-your-first-component? I guess it's not needed because the dependencies are hardcoded.

@oliviertassinari oliviertassinari added enhancement This is not a bug, nor a new feature and removed core Infrastructure work going on behind the scenes labels Dec 27, 2023
@LukasTy LukasTy requested a review from a team December 28, 2023 07:45
@LukasTy
Copy link
Member Author

LukasTy commented Dec 28, 2023

I changed the label to be docs-infra. This looks about having the proper abstraction level, it was a leaky abstraction before.

Thanks, in that case, I've asked for a review from docs-infra. 👍

What about this demo though https://mui.com/x/react-date-pickers/getting-started/#render-your-first-component? I guess it's not needed because the dependencies are hardcoded.

It's the same as for all the other demos. We moved the relevant related dependency resolving into mui-x to have better control over it and avoid fighting the logic existing in "monorepo".

@LukasTy LukasTy merged commit feba7bf into mui:master Jan 8, 2024
19 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
@LukasTy
Copy link
Member Author

LukasTy commented Jan 12, 2024

Warning

This branch should not be deleted, because it is used for v6 (master) and will remain being used for docs-v6, even after v7 becomes stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature MUI X scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants