Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] v5.14.18 #39873

Merged
merged 8 commits into from
Nov 14, 2023
Merged

[release] v5.14.18 #39873

merged 8 commits into from
Nov 14, 2023

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Nov 13, 2023

Lerna failed with partial updates. The log is too vague for me to be able to investigate what is happening. I am posting here the cmd output for easier verification of the version updates:

Changes:
 - benchmark: 5.0.0 => 5.0.0 (private)
 - docs: 5.0.0 => 5.0.0 (private)
 - @mui-internal/api-docs-builder: 1.0.0 => 1.0.0 (private)
 - @mui-internal/api-docs-builder-core: 1.0.0 => 1.0.0 (private)
 - eslint-plugin-material-ui: 5.0.0 => 5.0.0 (private)
 - feedback: 5.0.0 => 5.0.0 (private)
 - @mui/markdown: 5.0.0 => 5.0.0 (private)
 - @mui/base: 5.0.0-beta.23 => 5.0.0-beta.24
 - @mui/codemod: 5.14.15 => 5.14.18
 - @mui/core-downloads-tracker: 5.14.17 => 5.14.18
 - @mui/docs: 5.14.17 => 5.14.18
 - @mui/envinfo: 2.0.12 => 2.0.13
 - @mui/icons-material: 5.14.16 => 5.14.18
 - @mui/joy: 5.0.0-beta.14 => 5.0.0-beta.15
 - @mui/lab: 5.0.0-alpha.152 => 5.0.0-alpha.153
 - @mui/material: 5.14.17 => 5.14.18
 - @mui/material-next: 6.0.0-alpha.109 => 6.0.0-alpha.110
 - @mui/private-theming: 5.14.17 => 5.14.18
 - @mui/styled-engine: 5.14.17 => 5.14.18
 - @mui/styled-engine-sc: 6.0.0-alpha.5 => 6.0.0-alpha.6
 - @mui/styles: 5.14.17 => 5.14.18
 - @mui/system: 5.14.17 => 5.14.18
 - @mui/types: 7.2.8 => 7.2.9
 - @mui/utils: 5.14.17 => 5.14.18
 - rsc-builder: 1.0.0 => 1.0.0 (private)
 - @mui-internal/test-utils: 1.0.0 => 1.0.0 (private)
 - typescript-to-proptypes: 5.0.0 => 5.0.0 (private)
 - @mui/zero-jest: 0.0.1-alpha.0 => 0.0.1-alpha.0 (private)
 - @mui/zero-next-plugin: 0.0.1-alpha.0 => 0.0.1-alpha.0 (private)
 - @mui/zero-runtime: 0.0.1-alpha.0 => 0.0.1-alpha.0 (private)
 - @mui/zero-tag-processor: 0.0.1-alpha.0 => 0.0.1-alpha.0 (private)
 - @mui/zero-vite-plugin: 0.0.1-alpha.0 => 0.0.1-alpha.0 (private)
 - @mui-internal/tests: 5.0.0 => 5.0.0 (private)

? Are you sure you want to create these versions? Yes
lerna info execute Skipping git tag/commit
lerna info execute Skipping git push
lerna info execute Skipping releases
lerna WARN ECYCLE Dependency cycles detected, you should fix these!
lerna WARN ECYCLE @mui/material -> @mui/base -> @mui/material
lerna WARN ECYCLE @mui/material -> @mui/system -> @mui/private-theming -> @mui/material
lerna WARN ECYCLE @mui/private-theming -> @mui/styles -> @mui/private-theming
lerna WARN ECYCLE @mui/system -> @mui/private-theming -> @mui/styles -> @mui/joy -> @mui/system
lerna WARN ECYCLE @mui/material -> @mui/system -> @mui/private-theming -> @mui/styles -> @mui/joy -> @mui/material
lerna WARN ECYCLE @mui/material -> @mui/system -> @mui/private-theming -> @mui/styles -> @mui/material
lerna WARN ECYCLE @mui/material -> @mui/system -> @mui/material
lerna WARN ECYCLE @mui/material -> @mui/system -> @mui/material-next -> @mui/material
lerna WARN ECYCLE @mui/system -> @mui/material-next -> @mui/system
lerna ERR! ERROR Not all tasks were run. This is likely a bug in Lerna.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@mnajdova mnajdova added the release We are shipping :D label Nov 13, 2023
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @mui/utils version wasn't updated in all packages. Additionally, version updates were missed in the following files:

  • root package.json
  • docs/package.json
  • test/package.json

CHANGELOG.md Outdated Show resolved Hide resolved
packages/mui-base/package.json Outdated Show resolved Hide resolved
packages/mui-docs/package.json Outdated Show resolved Hide resolved
packages/mui-joy/package.json Outdated Show resolved Hide resolved
packages/mui-joy/package.json Outdated Show resolved Hide resolved
packages/mui-lab/package.json Outdated Show resolved Hide resolved
packages/mui-material-next/package.json Outdated Show resolved Hide resolved
packages/mui-styled-engine-sc/package.json Show resolved Hide resolved
@mui-bot
Copy link

mui-bot commented Nov 14, 2023

Netlify deploy preview

https://deploy-preview-39873--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 2defc09

@mnajdova mnajdova marked this pull request as ready for review November 14, 2023 07:23
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍. Just need to update the release date.

Signed-off-by: Zeeshan Tamboli <[email protected]>
@mnajdova
Copy link
Member Author

Looks good to me 👍. Just need to update the release date.

Thanks for verifying this Zeeshan! I am doing the release now

@mnajdova mnajdova merged commit 43a41b6 into mui:master Nov 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release We are shipping :D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants