[material-ui][AvatarGroup] Add renderSurplus prop
#39283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
zannager
added
the
component: avatar
danilo-leal
changed the title
renderSurplus prop
danilo-leal
added
package: material-ui
|
The code looks good to me! let's add a demo next to https://mui.com/material-ui/react-avatar/#total-avatars ### Custom surplus
Set `renderSurplus` prop as a callback to customize the surplus avatar. The callback will receive one argument which is the number of surpluses based on the children and `max` prop.
This is useful when you need to render the surplus based on the data sent from the server.
// demo |
|
@siriwatknp done |
siriwatknp
approved these changes
Oct 10, 2023
DiegoAndai
requested changes
Oct 10, 2023
There was a problem hiding this comment.
Hey @uuxxx! thanks for working on this
I left two writing improvements and a question, let me know what you think 😊
mnajdova
approved these changes
Oct 11, 2023
DiegoAndai
reviewed
Oct 11, 2023
Signed-off-by: Diego Andai <[email protected]>
DiegoAndai
approved these changes
Oct 11, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Oct 13, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Oct 13, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Avatar element
According to @siriwatknp comment, add renderSurplus prop.
possible solution to #39204