[Portal] Improve docs for container prop #39180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
Netlify deploy previewBundle size report |
| @@ -27,7 +27,7 @@ export default function ServerModal() { | |||
| open | |||
| aria-labelledby="server-modal-title" | |||
| aria-describedby="server-modal-description" | |||
| container={() => rootRef.current} | |||
| container={() => rootRef.current!} | |||
There was a problem hiding this comment.
The ref is guaranteed to be defined when it runs in an effect.
| @@ -4,7 +4,7 @@ | |||
| <Box sx={{ p: 1, my: 1, border: '1px solid' }}> | |||
| It looks like I will render here. | |||
| {show ? ( | |||
| <Portal container={container.current}> | |||
| <Portal container={() => container.current!}> | |||
There was a problem hiding this comment.
In case developers use this withshow={true} by default.
| import Box from '@mui/material/Box'; | ||
| import Portal from '@mui/material/Portal'; | ||
|
|
||
| export default function SimplePortal() { |
oliviertassinari
force-pushed
the
improve-portal-container-prop
branch
from
9f1c97a to
edb5343
Compare
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
force-pushed
the
improve-portal-container-prop
branch
from
edb5343 to
596ec1b
Compare
github-actions
bot
removed
the
PR: out-of-date
Co-authored-by: Sam Sycamore <[email protected]> Signed-off-by: Olivier Tassinari <[email protected]>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 30, 2023
Signed-off-by: Olivier Tassinari <[email protected]> Co-authored-by: Sam Sycamore <[email protected]>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 1, 2023
Signed-off-by: Olivier Tassinari <[email protected]> Co-authored-by: Sam Sycamore <[email protected]>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 1, 2023
Signed-off-by: Olivier Tassinari <[email protected]> Co-authored-by: Sam Sycamore <[email protected]>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
Signed-off-by: Olivier Tassinari <[email protected]> Co-authored-by: Sam Sycamore <[email protected]>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
Signed-off-by: Olivier Tassinari <[email protected]> Co-authored-by: Sam Sycamore <[email protected]>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
Signed-off-by: Olivier Tassinari <[email protected]> Co-authored-by: Sam Sycamore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on mui/mui-x#10188 (comment)
Preview: https://deploy-preview-39180--material-ui.netlify.app/base-ui/react-portal/