Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joy-ui][AccordionGroup] Fix console warning when using custom color #38950

Merged
merged 6 commits into from
Sep 18, 2023
Merged

[joy-ui][AccordionGroup] Fix console warning when using custom color #38950

merged 6 commits into from
Sep 18, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Sep 13, 2023 •
edited
Loading

closes: #38688

resolves: #38688 (comment) comment

@sai6855 sai6855 added bug 🐛 Something doesn't work component: accordion This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Sep 13, 2023
@mui-bot
Copy link

mui-bot commented Sep 13, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-38950--material-ui.netlify.app/

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/private-theming: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%
@mui/material-next: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: +Infinity% , gzip: +Infinity%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 19e6071

sai6855
sai6855 commented Sep 13, 2023
View reviewed changes
packages/mui-joy/src/AccordionGroup/AccordionGroup.test.tsx Outdated

it('should not warn when using custom color', () => {
expect(() => {
// @ts-expect-error as `custom` color is not part of the type system
Copy link
Contributor Author

@sai6855 sai6855 Sep 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using @ts-expect-error, we can follow this guide (https://mui.com/joy-ui/customization/theme-colors/#adding-new-palettes) and fix ts issue, but i felt it will become bit over board for the test

@sai6855 sai6855 requested a review from siriwatknp September 13, 2023 12:19
@oliviertassinari oliviertassinari mentioned this pull request Sep 13, 2023
Closed
siriwatknp
siriwatknp approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Thanks for the fix!

@siriwatknp siriwatknp merged commit 1895fc3 into mui:master Sep 18, 2023
@sai6855 sai6855 deleted the accordion-prop branch September 18, 2023 03:50
danilo-leal pushed a commit to siriwatknp/material-ui that referenced this pull request Sep 18, 2023
@sai6855 @danilo-leal
[joy-ui][AccordionGroup] Fix console warning when using custom color (m…
84a1d0d 
…ui#38950)
christophermorin pushed a commit to christophermorin/material-ui that referenced this pull request Sep 21, 2023
@sai6855 @christophermorin
[joy-ui][AccordionGroup] Fix console warning when using custom color (m…
650322b 
…ui#38950)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: accordion This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
3 participants
@sai6855 @mui-bot @siriwatknp