Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix codemod name in changelog of v5.14.4 #38593

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

GresilleSiffle
Copy link
Contributor

@GresilleSiffle GresilleSiffle commented Aug 22, 2023


Hello maintainers,

I saw that the release note 5.14.4 in CHANGELOG.md invites the developers to run this codemod command:

npx @mui/codemod v5.0.0/base-use-named-imports <path>

Unfortunately this command doesn't exist. It looks like the correct command ends with "-exports":

npx @mui/codemod v5.0.0/base-use-named-exports <path>

See:

The release note 5.14.4 invites the developers to run this cmd:
- v5.0.0/base-use-named-imports

But this command doesn't exist, the following cmd should be
run instead:
- v5.0.0/base-use-named-exports 

See:
- https://github.com/mui/material-ui/blob/1e418e64ff2564878bb059a27d4120c3cbdeb9db/packages/mui-codemod/README.md#base-use-named-exports

Signed-off-by: Gresille & Siffle <[email protected]>
@mui-bot
Copy link

mui-bot commented Aug 22, 2023

Netlify deploy preview

https://deploy-preview-38593--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 518840e

@ZeeshanTamboli ZeeshanTamboli added the docs Improvements or additions to the documentation label Aug 22, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] fix codemod name in changelog of 5.14.4 [docs] Fix codemod name in changelog of 5.14.4 Aug 22, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Fix codemod name in changelog of 5.14.4 [docs] Fix codemod name in changelog of v5.14.4 Aug 22, 2023
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GresilleSiffle Looks good. Nice catch! Thank you for your first contribution!

@ZeeshanTamboli ZeeshanTamboli merged commit 7cb6f20 into mui:master Aug 22, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants