Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix generate Proptypes script skipping unstable items #38198

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Jul 28, 2023

There is some logic that filter out files where the directory name and filename doesn't match, e.g. Modal/ModalManager.d.ts

But we need to make an exception for Unstable_/unstable_, as we do want Proptypes generated for e.g. Unstable_Grid/Grid.tsx

@mj12albert mj12albert added the core Infrastructure work going on behind the scenes label Jul 28, 2023
@mui-bot
Copy link

mui-bot commented Jul 28, 2023

Netlify deploy preview

https://deploy-preview-38198--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 58db377

@mj12albert mj12albert requested review from mnajdova, michaldudak and a team July 28, 2023 08:46
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@mj12albert mj12albert merged commit 55fb595 into mui:master Jul 28, 2023
@mj12albert mj12albert deleted the proptypes-unstable branch July 28, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants