Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript][base] Rename one letter type parameters #38171

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

michaldudak
Copy link
Member

Similarly to #38155, in this PR I renamed one-letter type parameters in Base's type maps and props to something more meaningful.

@michaldudak michaldudak added typescript package: base-ui Specific to @mui/base labels Jul 26, 2023
@michaldudak michaldudak requested a review from mj12albert July 26, 2023 14:27
@mui-bot
Copy link

mui-bot commented Jul 26, 2023

Netlify deploy preview

https://deploy-preview-38171--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 4a74014

Copy link
Member

@mj12albert mj12albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very helpful 👍

@michaldudak michaldudak merged commit 495d3f7 into mui:master Jul 27, 2023
@michaldudak michaldudak deleted the type-params-base branch July 27, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: base-ui Specific to @mui/base typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants