[Menu][Divider] Do not allow focus on Divider when inside Menu list #38102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-38102--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
divyammadhok
force-pushed
the
menu-disabled-focus-fix
branch
from
87dbbce to
9e9bec3
Compare
2 tasks
zannager
added
component: divider
There was a problem hiding this comment.
@divyammadhok The logic makes sense. Could you kindly add a test case to verify the fix? It can be added in packages\mui-material\src\Menu\Menu.test.js. Thanks.
ZeeshanTamboli
added
bug 🐛
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
ZeeshanTamboli
approved these changes
Jul 28, 2023
|
@ZeeshanTamboli Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37306
Description
The issue was that if a list of menu items also contains a divider, and all menu items are disabled, tabindex=0 will be set on the divider.