[Popover] Fix rendering for nested Menus #3806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
material-ui/issues/3586 changed `<noscript>` to `<div>` to resolve an issue with react-event-listener and nested `<noscript>` That change broke layout for nested Menus. This change fixes that.
| @@ -380,7 +380,7 @@ const Popover = React.createClass({ | |||
|
|
|||
| render() { | |||
| return ( | |||
| <div> | |||
| <div style={{display: 'none'}}> | |||
There was a problem hiding this comment.
What about moving the style object outside of the render method in a getStyles method?
There was a problem hiding this comment.
I wondered, but seemed like overkill given there are no other styles in that component.
There was a problem hiding this comment.
Good point, or having a ?
const styles = {
root: {
display: 'none',
},
};There was a problem hiding this comment.
Either way, it was a lot of extra lines for a one-line fix, and an unnecessary abstraction. We're never going to add more styles, so I vote to leave it, but if it really bothers you that much, I'll change it. 😄
There was a problem hiding this comment.
There was a problem hiding this comment.
@sibelius if you were to submit a PR following this rule I wouldn't object.
|
@mbrookes Thanks 👍. |
3 tasks
zannager
added
component: Popover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/ docs demo, and is linted.[Popover] Invariant Violation: findComponentRoot(...) from unclosed <noscript> #3586 changed
<noscript>to<div>to resolve an issue with react-event-listener and nested
<noscript>That change broke layout for nested
Menus. This change fixes that.Closes #3802.