[Autocomplete] Add new AutocompleteInputChangeReason #37301
Merged
+225
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
zannager
added
the
component: autocomplete
mj12albert
changed the title
michaldudak
changed the title
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
8 tasks
|
Hi! isn't this PR missing things from the original one (#37013)? for example this change. |
aarongarciah
force-pushed
the
autocomplete-resetInputValue-reason-2
branch
from
9bbfb41 to
82e36d9
Compare
|
I added the missing changes that were present in #37013 |
aarongarciah
added
package: material-ui
|
@michaldudak @DiegoAndai this is ready for review. |
DiegoAndai
reviewed
Jun 26, 2024
There was a problem hiding this comment.
@aarongarciah we should add the following
- A section in the v6 migration guide explaining the change and how to adapt
- Tests for the introduced reasons
Do you agree? Are we missing anything else?
|
@DiegoAndai that should cover everything. I'll add it. |
github-actions
bot
added
the
PR: out-of-date
aarongarciah
force-pushed
the
autocomplete-resetInputValue-reason-2
branch
from
b5b2ba8 to
41351fa
Compare
github-actions
bot
removed
the
PR: out-of-date
aarongarciah
force-pushed
the
autocomplete-resetInputValue-reason-2
branch
from
41351fa to
c33f43f
Compare
aarongarciah
reviewed
Jul 4, 2024
aarongarciah
reviewed
Jul 4, 2024
Comment on lines
128
to
130
| - `"blur"`: like `"reset"` but triggered when the focus is moved off the input. `clearOnBlur` must be `true`. Before, it was treated as `"reset"`. | ||
| - `"selectOption"`: triggered when the input value changes after an option has been selected. Before, it was treated as `"reset"`. | ||
| - `"removeOption"`: triggered in multiple selection when a chip gets removed due to the corresponding option being selected. Before, it was treated as `"reset"`. |
There was a problem hiding this comment.
@michaldudak let me know if these descriptions are accurate.
|
@DiegoAndai just pushed the tests covering the missing |
DiegoAndai
reviewed
Jul 10, 2024
There was a problem hiding this comment.
Nice @aarongarciah! One final question. Do you think we should take this opportunity to use user event instead of fireEvent on these tests? If you prefer doing it on a separate PR, that's ok. Let me know.
docs/data/material/migration/migrating-to-v6/migrating-to-v6.md
Outdated
Show resolved
Hide resolved
aarongarciah
force-pushed
the
autocomplete-resetInputValue-reason-2
branch
from
9a5b265 to
5adc07f
Compare
|
@DiegoAndai all tests updated to use the new |
DiegoAndai
approved these changes
Jul 11, 2024
1 task
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Co-authored-by: Aarón García Hervás <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #36085
duplicate of #37013