[Base][useButton] Allow useButton params to be completely optional #36922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
component: button
Netlify deploy previewhttps://deploy-preview-36922--material-ui.netlify.app/ Bundle size report |
mj12albert
changed the title
mj12albert
force-pushed
the
36879-basebutton-allow-usebutton-parameters-to-be-completely-optional
branch
from
c2bdf6a
to
4cd72c9
Compare
michaldudak
reviewed
Apr 18, 2023
| @@ -20,7 +20,7 @@ import { EventHandlers } from '../utils/types'; | |||
| * | |||
| * - [useButton API](https://mui.com/base/api/use-button/) | |||
| */ | |||
| export default function useButton(parameters: UseButtonParameters): UseButtonReturnValue { | |||
| export default function useButton(parameters?: UseButtonParameters): UseButtonReturnValue { | |||
There was a problem hiding this comment.
IMO it would be safer to specify it as:
Suggested change
| export default function useButton(parameters?: UseButtonParameters): UseButtonReturnValue { | |
| export default function useButton(parameters: UseButtonParameters = {}): UseButtonReturnValue { |
This way, parameters will always be defined inside the body. Plus, it's shorter :)
There was a problem hiding this comment.
You are right ~ I totally overcomplicated this 😅
mj12albert
force-pushed
the
36879-basebutton-allow-usebutton-parameters-to-be-completely-optional
branch
from
4cd72c9
to
726a06f
Compare
siriwatknp
approved these changes
Apr 21, 2023
mj12albert
deleted the
36879-basebutton-allow-usebutton-parameters-to-be-completely-optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36879