[docs] Improve side nav scroll into view #36732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
design
oliviertassinari
force-pushed
the
fix-sidenav-scroll-into-view
branch
from
ff39f43 to
f9fbb37
Compare
Netlify deploy previewhttps://deploy-preview-36732--material-ui.netlify.app/ Bundle size report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this during the review of #35938. We need to reset the scroll sooner than what we anticipate for:
KO: open https://mui.com/material-ui/react-checkbox/ with a browser width small enough, see how the active link is cut, it's disorienting.
What we want, is to have the active link always in the viewport, and to also account for the URL overlay:
Preview: https://deploy-preview-36732--material-ui.netlify.app/material-ui/react-checkbox/. It's a new iteration on the logic, something we had many iterations on already, e.g. the last one #25619.
Out of scope
There is still one thing that I HATE about the current page navigation experience is that the whole side nav rerenders on each page change, we lose all the DOM state, which means:
Screen.Recording.2023-04-01.at.13.56.12.mov
Screen.Recording.2023-04-01.at.13.57.31.mov
The solution is to use a Layout component, like explored in #20907 and #36207. Actually, Marija used getLayout for Base UI in #35938 🎉