Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InputLabel] Change size prop option from normal to medium #36188

Open
wants to merge 1 commit into
base: v5.x
Choose a base branch
from

Conversation

TurtIeSocks
Copy link
Contributor

  • Replaces normal with medium
  • More in line with size props in the rest of the package(s)
  • As far as I can tell, this is the only component that uses small/normal as the size options, opposed to small/medium

I didn't leave it "backwards compatible" since the size prop is not used when it's set to default/normal anyway, but I can adjust that if normal should be type supported until the next major version.

- Replace `normal` with `medium`
- More in line with size props in the rest of the package(s)
@mui-bot
Copy link

mui-bot commented Feb 14, 2023

Netlify deploy preview

https://deploy-preview-36188--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 7e36685

@zannager zannager added the component: FormControl The React component label Feb 15, 2023
@zannager zannager requested a review from michaldudak February 15, 2023 08:27
@michaldudak
Copy link
Member

Thanks for your PR. Indeed this seems like the only place we use the term "normal" when describing size.
However, even though this is the default value, there may be implementations where developers use it explicitly. We don't want to introduce breaking changes outside of major versions.
I'm happy to assign it to the v6 milestone and include it in that release.

@michaldudak michaldudak added on hold There is a blocker, we need to wait enhancement This is not a bug, nor a new feature labels Feb 15, 2023
@michaldudak michaldudak added this to the v6 milestone Feb 15, 2023
@TurtIeSocks
Copy link
Contributor Author

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: FormControl The React component enhancement This is not a bug, nor a new feature on hold There is a blocker, we need to wait PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants