-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[base-ui] Remove classes
prop from the Base UI components that have it
#36157
Conversation
classes
prop from the Base components that have it
Netlify deploy previewhttps://deploy-preview-36157--material-ui.netlify.app/ Bundle size report |
After the change, it's not possible to add custom classes to the Modal (I haven't checked the other components). Could you please take a look at it? |
ea212a0
to
7cc2a2b
Compare
I think this is ready for 2nd review. I'd appreciate it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you don't mind the review. Just saw this PR after #35963 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works much better now. Good job adding the tests!
580946d
to
4ef4b3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid!
aef0b10
to
0ce683c
Compare
@hbjORbj would be great if you can provide a Breaking changes section in the PR description next time when there is a breaking change involved. This will make the release much faster. |
Gottcha. On it. |
classes
prop from the Base components that have itclasses
prop from the Base UI components that have it
Breaking Changes
classes
prop is removed fromModalUnstyled
,SliderUnstyled
,TablePaginationUnstyled
andTablePaginationActionsUnstyled
.You can replace the
classes
prop by providing the class name prop directly to the prop viaslotProps
. Below is an example of how the migration should look like:Closes #36129
Changes:
ModalUnstyled
,SliderUnstyled
,TablePaginationUnstyled
andTablePaginationActionsUnstyled
still supportclasses
prop. This PR drops the prop from these components.