Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] Fix border color for secondary disabled button #35866

Merged
merged 1 commit into from
Jan 23, 2023
Merged

[Button] Fix border color for secondary disabled button #35866

merged 1 commit into from
Jan 23, 2023

Conversation

SaidMarar
Copy link
Contributor

Fixes: #35851

Standardize the border color for secondary button when it is disabled.

@mui-bot
Copy link

mui-bot commented Jan 18, 2023 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-35866--material-ui.netlify.app/

Details of bundle changes

Generated by 🚫 dangerJS against 155ce3c

@zannager zannager added the component: button This is the name of the generic UI component, not the React module! label Jan 19, 2023
@zannager zannager requested a review from michaldudak January 19, 2023 10:05
danilo-leal
danilo-leal approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! That definitely felt like a bug as there seems to be no particular reason as to why that was different 🤔

@danilo-leal danilo-leal merged commit 7c1c73f into mui:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

@michaldudak michaldudak Awaiting requested review from michaldudak

Assignees
No one assigned
Labels
component: button This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Button] Inconsistent border opacity when disabled, secondary color, and outlined variant
4 participants
@SaidMarar @mui-bot @danilo-leal @zannager