[ListboxUnstyled] Fix option state highlighted to prevent unnecessary focus #35838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zannager
added
component: menu
siriwatknp
requested review from
michaldudak,
mj12albert and
hbjORbj
and removed request for
mnajdova
mnajdova
requested review from
siriwatknp
and removed request for
michaldudak and
hbjORbj
mnajdova
added
component: list
mnajdova
requested review from
michaldudak
and removed request for
siriwatknp
|
I updated the broken link test of the fix: https://codesandbox.io/s/fix-listbox-uvx06z?file=/demo.js |
|
Thanks for the fix. Would you mind adding a test to verify the behavior? |
…m is the only one that receive focus
@michaldudak done check it out 😉 |
michaldudak
reviewed
Jan 29, 2023
SaidMarar
requested review from
michaldudak
and removed request for
mj12albert
michaldudak
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #35780
This fix the bad focus on options when the list is initialized, In this case the findIndex will always return -1 for the index of the option because the array options is not filled yet.
before: https://codesandbox.io/s/k0zipv?file=/demo.js:0-1083
after: https://codesandbox.io/s/fix-listbox-uvx06z?file=/demo.js
Problem
highlighted: highlightedIndex === index, // this will be always true as long as the options array is emptyFix
Force condition by checking index is not equal to -1 when the options is empty