Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Remove next-env.d.ts from Next.js examples #35772

Merged
merged 1 commit into from
Jan 16, 2023
Merged

[examples] Remove next-env.d.ts from Next.js examples #35772

merged 1 commit into from
Jan 16, 2023

Conversation

Juneezee
Copy link
Contributor

@Juneezee Juneezee commented Jan 9, 2023

next-env.d.ts should not be committed and should be ignored by version control.

image

Source: https://nextjs.org/docs/basic-features/typescript#existing-projects


The default .gitignore template for create-next-app has also been updated to ignore next-env.d.ts in this PR: vercel/next.js#39051

`next-env.d.ts` should not be committed and should be ignored by version
control [1].

[1]: https://nextjs.org/docs/basic-features/typescript#existing-projects

Signed-off-by: Eng Zer Jun <[email protected]>
@mui-bot
Copy link

mui-bot commented Jan 9, 2023

Messages
📖 Netlify deploy preview: https://deploy-preview-35772--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 960fd4f

@ZeeshanTamboli ZeeshanTamboli added the examples Relating to /examples label Jan 9, 2023
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@mnajdova mnajdova merged commit d1088e6 into mui:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Relating to /examples nextjs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants